Lock down _uid field
#9836
Merged
Lock down _uid field
#9836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,7 +302,7 @@ protected String buildFullName(BuilderContext context) { | |||
| protected FieldDataType fieldDataType; | |||
| protected final MultiFields multiFields; | |||
| protected CopyTo copyTo; | |||
| protected final boolean writePre20Metadata; | |||
| protected final boolean writePre20Settings; | |||
There was a problem hiding this comment.
Is it possible to name this something else? I see writePre20Settings and I think pre-0.20.0 version
There was a problem hiding this comment.
I renamed to writePre2xSettings. Hopefully 2x is more readable.
rjernst
added
v2.0.0-beta1
:Search Foundations/Mapping
|
LGTM, left one trivial subjective comment |
rjernst
force-pushed
the
fix/8143-uid
branch
from
bdc892c to
73bb81e
Compare
Also, cleanup writePre20Settings so it is shared across all field mappers. see elastic#8143
rjernst
force-pushed
the
fix/8143-uid
branch
from
73bb81e to
822ffe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, cleanup writePre20Settings so it is shared across all field mappers.
see #8143